Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action v11 with fixes and modern setup #29

Merged
merged 20 commits into from
Nov 28, 2023
Merged

Action v11 with fixes and modern setup #29

merged 20 commits into from
Nov 28, 2023

Conversation

d-koppenhagen
Copy link
Contributor

@cmgriffing would you mind to check this out? I modernized the whole setup of the repo based on:
https://github.com/actions/typescript-action

I fixed also some issues and updated the documentation.

@d-koppenhagen
Copy link
Contributor Author

I think some pipeline steps are failing since I have no valid access_token. @cmgriffing probably this works I you are running the pipeline.

@cmgriffing
Copy link
Owner

Nice, thanks. I think I made a mistake in approving and merging some other commits first. Could you fix those conflicts?
After that, I can just merge it in, and we can see if the tests pass then.

cmgriffing
cmgriffing reviewed Nov 27, 2023
View reviewed changes
.prettierrc.json Outdated Show resolved Hide resolved
@socket-security Socket Security
Copy link

socket-security bot commented Nov 27, 2023 •
edited
Loading

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@vercel/ncc 0.38.1 eval, filesystem, shell, environment +0 16.6 MB vercel-release-bot
eslint-plugin-jsonc 2.10.0 None +30 7.92 MB ota-meshi
eslint-plugin-github 4.10.1 filesystem, shell +195 68.8 MB githubbot
prettier-eslint 16.1.2 None +56 52.2 MB zimme
eslint-plugin-jest 27.6.0 shell +171 59.4 MB simenb
@typescript-eslint/eslint-plugin 5.7.0...6.13.0 None +43/-38 44.6 MB
husky 7.0.4...8.0.3 None +0/-0 6.44 kB typicode
jest 27.4.5...29.7.0 shell +127/-177 12.9 MB simenb
@typescript-eslint/parser 5.7.0...6.13.0 None +38/-35 41.7 MB
@actions/io 1.1.1...1.1.3 None +0/-0 37.1 kB thboop
ts-jest 27.1.1...29.1.1 shell +129/-180 45.2 MB kul
@actions/exec 1.1.0...1.1.1 None +1/-1 92.5 kB thboop
@types/jest 27.0.3...29.5.10 environment +25/-12 5.29 MB types
@actions/github 5.0.0...5.1.1 None +5/-3 1.45 MB thboop
@actions/core 1.6.0...1.10.1 network, filesystem, environment +3/-1 1.4 MB thboop
@types/node 16.11.12...20.10.0 None +1/-0 4 MB types
prettier 2.5.1...3.1.0 None +0/-0 8.44 MB prettier-bot
eslint-plugin-prettier 4.0.0...5.0.1 None +57/-25 16.9 MB jounqin
eslint 8.4.1...8.54.0 None +26/-23 7.57 MB eslintbot
typescript 4.5.3...5.3.2 None +0/-0 32 MB typescript-bot

🚮 Removed packages: @types/[email protected], @types/[email protected], @yarnpkg/[email protected], @zeit/[email protected], [email protected]

@cmgriffing cmgriffing merged commit c3b5b4b into cmgriffing:master Nov 28, 2023
4 checks passed
@cmgriffing
Copy link
Owner

Merged, let's double check things work.

THANK YOU SO MUCH @d-koppenhagen !!!

@d-koppenhagen
Copy link
Contributor Author

awesome. Once you checked, can you draft the v11 release?

@d-koppenhagen
Copy link
Contributor Author

I tested it with my blog using the SHA of the Commit after the merge and everything seems to work:

Pipeline:
https://github.com/d-koppenhagen/k9n.dev/actions/runs/7015168587/job/19084033853

Related Commit:
d-koppenhagen/k9n.dev@0afa75c

@d-koppenhagen d-koppenhagen deleted the v11 branch November 28, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmgriffing cmgriffing cmgriffing left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@d-koppenhagen @cmgriffing